V1 Fixed incorrect progress values for status events in stl serializer

jscad / io

DEPRECATED : Input Output handling for JSCAD (see the link below)

https://github.com/jscad/OpenJSCAD.org/tree/V2/packages

34 stars 13 forks source link

V1 Fixed incorrect progress values for status events in stl serializer #92

Closed paulhayes closed 3 years ago

z3dev commented 4 years ago

@paulhayes thanks for the fix. It looks fine.

However, V1 is really locked now. We are focusing on V2, and getting very close to a first release now. We would appreciate them same to V2 if you have time.

The V2 IO library is now found in the OpenJSCAD.org repository, under packages/io

paulhayes commented 4 years ago

Yeah I'll have a look.

z3dev commented 3 years ago

@paulhayes thanks for these changes.

i verified that this bug does not exist in the newer version of stl-serializer (part of OpenJSCAD.org now).

https://github.com/jscad/OpenJSCAD.org/tree/master/packages/io/stl-serializer

So, I will close the pull request.