jscad / openscad-openjscad-translator

DEPRECATED: Convert OpenSCAD to JSCAD (See the link below)
https://github.com/jscad/OpenJSCAD.org/tree/V2/packages
MIT License
22 stars 10 forks source link

Overall update #6

Closed kaosat-dev closed 7 years ago

kaosat-dev commented 7 years ago

Hi Gary ! how are you ? :) This PR adds a coat of 'fresh paint' to the translator and updates a number of things:

apla commented 7 years ago

Some things definitely broken. lodash.rest is not the same as underscore.rest. I'm trying to make converted output more readable, you can wait for a fix from me or fix it yourself, if you want.

Take a look: https://github.com/jscad/openscad-openjscad-translator/blob/master/src/openscad-parser-ext.js#L39

kaosat-dev commented 7 years ago

@apla wow thanks for finding that one ! I thought I had fixed all of them ! Will do asap ! Weird, all tests ran fine btw, plus openjscad + some extra tests did not pick it up

kaosat-dev commented 7 years ago

Fixed, there was another one in PrimitiveModules.js please let me know if you see anything else! And anything that makes output more readable is a good enhancement !