fixing angle-axis style rotation

jscad / scad-api

DEPRECATED: OpenSCAD like API for JSCAD (See the link below)

https://github.com/jscad/OpenJSCAD.org/tree/V2/packages

MIT License

14 stars 8 forks source link

fixing angle-axis style rotation #38

Closed ingobecker closed 3 years ago

ingobecker commented 6 years ago

I think this makes it a bit more openscad API compliant. I'm not very experienced in 3D stuff and hopefully didn't mess something up.

kaosat-dev commented 6 years ago

Hi @ingobecker and thanks a lot for this! Sorry for the late reply! This change does make sense and is not breaking any tests, so kudos ! :)

But, very sorry, we are deprecating this repository and moved its contents to csg.js to make changes and api overview easier to manage https://github.com/jscad/csg.js/tree/master/src/api. Would you mind re-applying your changes & tests there ?

Thanks in advance, sorry for the inconvenience !

ingobecker commented 6 years ago

Done. I wasn't aware that this is deprecated code not in use anymore. My mistake.

kaosat-dev commented 6 years ago

Not your fault at all @ingobecker , it was not (yet) made clear anywhere , so 100% our mistake, very sorry!