search

jscalo / tempi-fft

Real-time audio input and FFT written entirely in Swift for iOS.
253 stars 47 forks source link

hamming and hanning window types reversed in fftFoward #8

Closed muzzleburst closed 7 years ago

muzzleburst commented 7 years ago

Howdy, Thanks so much for contributing this library!

While reading through it, it looks like the fftForward function in TempiFFT/TempiFFT.swift lines 133-136, in the master branch, has the hamming and hanning switch cases reversed. When the case is .hamming, the vDSP_hann_window function is called, and when the case is .hanning, the vDSP_hamm_window function is called.

See the following link to the source code: https://github.com/jscalo/tempi-fft/blob/master/TempiFFT/TempiFFT.swift#L133

Is this expected?

Thank you! -Robert

jscalo commented 7 years ago

Good catch! It's almost a cruel joke that these two guys' names were so close together. (I know, one was Hann, but still!)