Closed thedavecarroll closed 1 year ago
I'll review the code when I have a free moment. There's a few things to address. First, the tests fail. Also, according to the documentation, I'm not sure that --force is required. Though I understand it could be useful to have in certain scenarios.
Definitely no rush and no pressure.
I agree on the --force
for SignIn()
and I don't recall why I thought I needed it.
If the tests are trying to run against the new SignIn()
, I'm not sure how that can be accomplished.
Not that it really matters, but I just ran the same commands dotnet build --configuration Release --no-restore
and dotnet test --configuration Release --no-build --verbosity normal
. The latter completed, but skipped all tests. :shrug:
Enjoy your weekend. I probably won't be back to my module until Tuesday.
Because tests are run against a real account, they will only run if enabled via the environment variables declared in TestBase.cs.
First, I'm not sure if I'm creating the pull request correctly. Feel free to close it if not and provide some guidelines.
I've only done minimal testing within my PowerShell module, but I think the revisions should not require any existing code changes for any consumers.
Here is my OPassCliPS repo if you wanted to check it out.