search

jscas / jscas-server

29 stars 6 forks source link

Fix hyperlinks to CAS in Readme.md #8

Closed styfle closed 6 years ago

styfle commented 6 years ago

It seems the github repo has been moved so I fixed the hyperlinks.

jsumners commented 6 years ago

Thank you for your contribution. Can you check to see if this is still a problem in the fastify branch?

styfle commented 6 years ago

Looks like it was fixed in that branch.

styfle commented 6 years ago

Although the protocol links to the github commit when it could link to https://apereo.github.io/cas/5.2.x/protocol/CAS-Protocol-Specification.html

jsumners commented 6 years ago

It's linked to the commit to prevent this exact issue from occurring again.

Would you be offended if this PR doesn't get merged? I'm closing in on a v1.0.0 release (from the fastify branch) and this will cause a merge conflict with it.

styfle commented 6 years ago

That's fine

jsumners commented 6 years ago

Thank you. I'm happy you like the project enough to contribute. I hope you'll find the upcoming release to be a significant improvement.

styfle commented 6 years ago

This is actually the first I'm hearing of CAS. I just tried clicking the links to read more about it and they were dead so I created the PR. Now I should probably actually read the docs 😬

Maybe you could set the fastify branch as the default in GitHub so newbies see the latest and greatest?

jsumners commented 6 years ago

It will become master soon. Hopefully by the end of the month.