search

jscert / jsexplain

Apache License 2.0
26 stars 4 forks source link

is_infix test in js_of_ast is broken #12

Closed brabalan closed 6 years ago

brabalan commented 7 years ago

The is_infix function compares directly locations, which is a record with many fields. It's a miracle that it worked until now.

We should directly compare the line number and column number inside the locations.

brabalan commented 6 years ago

This is fixed in master. Should we cherry pick the fix to the proxies branch? (Or we can just copy the code, as the fix was iterated over several commits.)

If we copy the code, we should copy the tests as well.

IgnoredAmbience commented 6 years ago

Cherry-picked into es2016-proxies