Makefile wildcards expension failed when dash is the sh shell

jscert / jsexplain

Apache License 2.0

26 stars 4 forks source link

Makefile wildcards expension failed when dash is the sh shell #33

Closed barockobamo closed 5 years ago

barockobamo commented 5 years ago

This happen on many of my debian machines. The clean section of Makefile was not able to execute these kind of command : clean : rm -f *.{cmi, cmo} We found out that we should ever :

change them as follow rm -f .cmi .cmo (Maybe the simplest way)
force the shell in Makefile
detect the shell and use different case (The worst way for my opinion)

IgnoredAmbience commented 5 years ago

Ah, I hadn't tested using dash before. I'm happy with the first option.

brabalan commented 5 years ago

As it seems that /bin/sh -> dash is the default on debian, we should not use curly braces expansion.

barockobamo commented 5 years ago

Removed Makefiles wildcard in clean section in #34