added dependecy to php match extension

[keywan-ghadami-oxid]

not tested, but maybe this kind of additional information in the composer.json helps to clarify the requirement of the php math extension

[majkel89]

+1

[bobmulder]

Because this extension isn't installed on my server I created the method thats used by the library myself. I would suggest that instead of adding this to the composer.json to prevent failures for those who doesn't have the extension installed.

[majkel89]

I assume you have written something like this:

if (!function_exists('bcmod')) {
    function bcmod() {
        // ...
    }
}

that should be boundled with library.

But still bcmath should be added to composer as suggestion

https://getcomposer.org/doc/04-schema.md#suggest

[bobmulder]

As suggestion that would be better I think.

You are right about the code ;)

[majkel89]

does the author is still alive ?

[keywan-ghadami-oxid]

seems so. last commit from @jschaedl was two days ago on an other project.

[jschaedl]

I added ext-bcmath as suggestion to composer.json and merged this pull request via command line.

[majkel89]

you should add bcmod polyfill too as described in https://github.com/jschaedl/Iban/issues/17

[jschaedl]

Would be nice if you can do it yourself and make a pull request then. Thank you.