jschaedl / iban-validation

:bank: A small library for validating International Bank Account Numbers (IBANs)
MIT License
88 stars 19 forks source link

violations are not cleared at the beginning of validate() #103

Closed jacekkarczmarczyk closed 1 year ago

jacekkarczmarczyk commented 1 year ago

Following code was working in 1.x but fails in 2.x because validations array is not cleared:


$validator = new Validator();

if ($validator->validate(/* invalid iban */) || $validator->validate(/* valid iban */)) {
  echo "One of the ibans is correct";
}
jschaedl commented 1 year ago

Thanks for reporting this. Would you like to provide a fix? Like you said, clearing the violations array at the beginning of the Validator::validate method (https://github.com/jschaedl/iban-validation/blob/master/src/Validator.php#L53) should fix it.

jacekkarczmarczyk commented 1 year ago

I'll give it a try

jschaedl commented 1 year ago

https://github.com/jschaedl/iban-validation/releases/tag/v2.0.1

@jacekkarczmarczyk Thanks again!

jacekkarczmarczyk commented 1 year ago

Cheers, thanks for release!