[2.x] Add support for php 8

jschaedl / iban-validation

:bank: A small library for validating International Bank Account Numbers (IBANs)

MIT License

88 stars 19 forks source link

[2.x] Add support for php 8 #53

Closed chris-doehring closed 3 years ago

chris-doehring commented 3 years ago

This PR add's support for php8.

php-cs-fixer had to be removed during build process, since it doesn't support php 8, yet
I upgraded the phpunit.xml.dist config to phpunit 9.3 standard

the Validator::bigIntModulo97 method had to drop it's nullable state, since phpstan correctly stated:

Method Iban\Validation\Validator::bigIntModulo97() never returns null so it can be removed from the return typehint.

mark9000 commented 3 years ago

I would really appreciate if this could be merged soon! This lib is a great tool and I need it PHP8 ready too as soon as possible. Thanks a lot!

jschaedl commented 3 years ago

@chris-doehring Thank you very much for your PR. I left a minor comment and could you please target branch 1.x.

chris-doehring commented 3 years ago

You are welcome! :) In that case I will create a new PR which is based on the 1.x branch, otherwise I would include your master changes.

chris-doehring commented 3 years ago

As correctly suggested, I created PR #54 to make version 1 compatible to php 8, but I guess you can also use this PR to make 2.x-dev compatible to php 8 as well, since a cherry picking of my 1.x changes could be problematic.

jschaedl commented 3 years ago

Thank you for you PR @chris-doehring!

I upmerged your changes from 1.x and removed all dev dependencies in #57. So closing this PR.