search

jschaedl / iban-validation

:bank: A small library for validating International Bank Account Numbers (IBANs)
MIT License
88 stars 19 forks source link

Compatibility with Symfony 6 #63

Closed Philipp91 closed 2 years ago

Philipp91 commented 2 years ago

Both symfony/options-resolver and symfony/yaml report "no significant changes" in their v6 changelog.

jschaedl commented 2 years ago

@Philipp91 Thanks for sending the PR. I would like to make version 1.7 compatible with Symfony 6 as well. Could you please target 1.x branch with your PR? Thank you!

Philipp91 commented 2 years ago

Seems like I can't, as GitHub then wants to also merge all the other commits from master. I can send a fresh PR? From the errors it sounds like the .phive config needs updating (though you probably know a lot more about that than me). Perhaps it's easiest to fix that, merge this, and then cherry-pick the two commits onto 1.x?

jschaedl commented 2 years ago

Please send a fresh PR with your changes based on branch 1.x. I will do an upmerge from 1.x into master afterwards.

Philipp91 commented 2 years ago

Closing this in favor of #64.