jschaf / esup

ESUP - Emacs Start Up Profiler
398 stars 22 forks source link

Byte compile warnings #68

Closed sergeyklay closed 4 years ago

sergeyklay commented 4 years ago

Hello,

There are byte compile warnings I would like avoid to. I hope most of them are trivial. Please let me know if I can help you with this.

In esup-child-profile-string:
esup-child.el:363:16: Warning: Obsolete name arg "esup-result" to constructor
    esup-result

In esup-child-serialize-result:
esup-child.el:407:13: Warning: Unknown slot ‘:file’
esup-child.el:406:5: Warning: Unknown slot ‘:start-point’
esup-child.el:409:5: Warning: Unknown slot ‘:line-number’
esup-child.el:411:5: Warning: Unknown slot ‘:expression-string’
esup-child.el:407:47: Warning: Unknown slot ‘:end-point’
esup-child.el:408:47: Warning: Unknown slot ‘:exec-time’
esup-child.el:409:47: Warning: Unknown slot ‘:gc-number’
esup-child.el:410:47: Warning: Unknown slot ‘:gc-time’
Compiling ~/.local/share/emacs/elpa/28.0.50/esup-20200120.740/esup-pkg.el...
Compiling ~/.local/share/emacs/elpa/28.0.50/esup-20200120.740/esup.el...

In esup-total-exec-time:
esup.el:163:46: Warning: Unknown slot ‘:exec-time’

In esup-total-gc-number:
esup.el:169:46: Warning: Unknown slot ‘:gc-number’

In esup-total-gc-time:
esup.el:175:44: Warning: Unknown slot ‘:gc-time’

In esup-drop-insignificant-times:
esup.el:183:39: Warning: Unknown slot ‘:exec-time’
../../../../../../.emacs.d/site-lisp/devtools.el: ‘defmethod’ is an obsolete macro (as of 25.1); use ‘cl-defmethod’ instead.
../../../../../../.emacs.d/site-lisp/devtools.el: ‘defgeneric’ is an obsolete macro (as of 25.1); use ‘cl-defgeneric’ instead.

In esup-fontify-results:
esup.el:557:15: Warning: Unknown slot ‘:expression-string’

In esup-next-separator-end-point:
esup.el:579:35: Warning: reference to free variable
    ‘esup-child-result-separator’
jschaf commented 4 years ago

I remember trying to solve this in the distant past. The details are fuzzy. Those slots all exist so I'm not sure what causes the warning.

I don't use esup much anymore so I won't get to this on any reasonable timeline.