jschaf / esup

ESUP - Emacs Start Up Profiler

398 stars 22 forks source link

Remove s lib as dep and replace with built-in or extraction. #83

Closed jcs090218 closed 4 years ago

jcs090218 commented 4 years ago

I have remove s dependency and replace it with built-in functions. And the esup-child-s-pad-left is the only function that is directly extracted from s lib.

This should directly fixed #81.

sergeyklay commented 4 years ago

@jcs090218, Could you please fix my typo: https://github.com/jschaf/esup/blob/b00d04fa03244238be048ea0d2aafb5e34779678/.github/workflows/build.yml#L82-L83 Need to replace BNF mode by Esup. I didn’t pay attention on this when did the GitHub Actions integration similar to the bnf-mode. Also make sure all tests pass. Thank you for the patch!

jcs090218 commented 4 years ago

@sergeyklay Fixed, does this work for you?

sergeyklay commented 4 years ago

I see the following error for Emacs 25-26:

esup-child.el:452:1:Error: the following functions are not known to be defined: string-trim-left, string-join

codecov-commenter commented 4 years ago

Codecov Report

Merging #83 into master will increase coverage by 0.46%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
+ Coverage   37.87%   38.34%   +0.46%     
==========================================
  Files           2        2              
  Lines         396      399       +3     
==========================================
+ Hits          150      153       +3     
  Misses        246      246

jcs090218 commented 4 years ago

I see the following error for Emacs 25-26:

esup-child.el:452:1:Error: the following functions are not known to be defined: string-trim-left, string-join

Adding subr-x should solved. :)

sergeyklay commented 4 years ago

Thank you!

phikal commented 3 years ago

Btw. s is still required in the header: https://github.com/jschaf/esup/blob/master/esup.el#L10