search

jschaf / pggen

Generate type-safe Go for any Postgres query. If Postgres can run the query, pggen can generate code for it.
MIT License
282 stars 26 forks source link

Creation of pull-request automatically triggers release? #51

Closed djsavvy closed 2 years ago

djsavvy commented 2 years ago

I just created https://github.com/jschaf/pggen/pull/50 and was amazed to see a release begin immediately. As far as I can tell, it is because the CI ran on a branch called "main" in my fork as well (see https://github.com/jschaf/pggen/blob/7f878880d5f9f7d25dec867850c6831e8c4402e7/.github/workflows/release.yaml#L5).

The release CI probably ought to check that it is actually running on this repo (assuming I correctly identified the root cause).

jschaf commented 2 years ago

Oh man, that's a proper foot gun. I think I fixed it in https://github.com/jschaf/pggen/commit/43bad0138c31130afd69dc90f208dfc278bde484 but Github actions are currently down, so I can't test until they fix that.

Thank you for reporting. I'll take down the release.