Don't activate which-function-mode automatically

jschaf / powershell.el

An Emacs mode for editing and running Microsoft PowerShell code.

93 stars 30 forks source link

Closed wasamasa closed 8 years ago

wasamasa commented 8 years ago

This is wrong for a few reasons:

I don't expect a function named powershell-setup-imenu to do anything else than setting up imenu
This violates the convention of loading up a mode not changing the overall Emacs (editing) behaviour
which-function-mode is a global minor mode, so this change applies not only in powershell buffers, but anywhere else as well

jschaf commented 8 years ago

Looks good to me and commit makes sense. Thanks for the pr.

wasamasa commented 8 years ago

Thanks!