search

jschaf / powershell.el

An Emacs mode for editing and running Microsoft PowerShell code.
94 stars 30 forks source link

Fix byte-compilation warnings #33

Closed morganwillcock closed 2 years ago

morganwillcock commented 2 years ago

This removes the following byte-compliation warnings.

Warning: (lambda (&optional x) \.\.\.) quoted with ' rather than with #'
Warning: the function 'cygwin-convert-file-name-from-windows’ is not known to be defined.

Hooks for window-size-change-functions look to take a single argument that is not optional, but I've switched &optional for &rest to make it forwards compatible if additional arguments are passed in the future and stay compatible with 0 arguments if that was needed for backwards compatibility.

juergenhoetzel commented 2 years ago

Thanks! side note: To silence byte-compiler warnings about unused variables, just use a variable name that starts with an underscore. The byte-compiler interprets this as an indication that this is a variable known not to be used.