search

jschanck / ntru

Implementations of the NIST post-quantum cryptography process finalist NTRU.
https://ntru.org
Creative Commons Zero v1.0 Universal
41 stars 8 forks source link

eliminate unused parameters and compiler warnings #23

Closed mariaschopp closed 3 years ago

mariaschopp commented 3 years ago

Function randombytes_init included a 'security' parameter that was not used. This has been removed.

GCC gave warnings on unused return values from fread. These are now handled and compiler warnings have been eliminated.

jschanck commented 3 years ago

Thanks for this PR. I would be happy to take the changes to test/decap.c and test/encap.c. The randombytes_init interface, however, was specified by NIST. So I'd prefer to silence the compiler warnings without changing the interface.

mariaschopp commented 3 years ago

That makes sense. I undid the changes to randombytes_init.

jschanck commented 3 years ago

Thanks for this! I've made your recommended changes to test/encap and test/decap.