search

jschauma / jass

a tool to facilitate sharing of secrets using SSH keys
MIT License
225 stars 24 forks source link

GitHub option uses LDAP, borks. #7

Closed rgbkrk closed 10 years ago

rgbkrk commented 10 years ago 
08:09:13 {master} ~/code/jass$ ./jass -V
jass version 3.0
08:09:19 {master} ~/code/jass$ echo "hey there" | ./jass -G -u rgbkrk
Unable to run 'ldapsearch -LLLxh ldap.local.twitter.com -b dc=ods,dc=twitter,dc=corp uid=rgbkrk twSSHPubkey':
ldap_sasl_bind(SIMPLE): Can't contact LDAP server (-1)

exit status 255

Excited if this could work for GitHub, GitHub Enterprise, GitLab, etc.

jschauma commented 10 years ago

Resolved via https://github.com/jschauma/jass/commit/3a601806e109ae163eb463c5255ec2a734443d22#diff-dd9fd0f28f12a4de5f1c6c40aae45ab2 and https://github.com/jschauma/jass/commit/0c4c6fd9a27914d9806af2207017a3691c1faeb4#diff-dd9fd0f28f12a4de5f1c6c40aae45ab2

(When merging from our internal version, which does use LDAP, I neglected to unset the variables. I'll have to look into a better way to build this conditionally.)