search

jscheid / prettier.el

Prettier code formatting for Emacs.
GNU General Public License v3.0
168 stars 12 forks source link

Tramp changes in Emacs 30 break prettier.el #120

Closed amake closed 1 year ago

amake commented 1 year ago

Describe the bug The changes in https://github.com/emacs-mirror/emacs/commit/54ef338ba3670415cf47fabc33a92d4904707c7e make the prettier process startup fail instantly with the message "Prettier timed out after 20 seconds".

Link to M-x prettier-info output https://gist.github.com/amake/a38b685517f3134ee53b44709256a105

To Reproduce

  1. Run Emacs 30 (on or after the above commit)
  2. Invoke any prettier.el function that causes the prettier process to start up

Expected behavior The process should start up and become usable

Additional context None

amake commented 1 year ago

I've reported this upstream as well: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61350#287

jscheid commented 1 year ago

Thanks for the heads up but I'm going to close this. If I understand correctly, 29 isn't released yet or was released very recently, and so 30 would be in pre-alpha or something. A breaking change in that particular API would be surprising, if there is going to be one feel free to reopen.