search

jscheid / prettier.el

Prettier code formatting for Emacs.
GNU General Public License v3.0
167 stars 12 forks source link

Add support for more major modes #14

Closed jscheid closed 4 years ago

asbish commented 4 years ago

Awesome work!

I have one question about these version strings. https://github.com/jscheid/prettier.el/blob/b315e2ed721c46f6b42d3d543e6d438536469b2c/prettier.el#L172 When do we need to update the strings in accordance with the prettier version in each plugin's dependencies or peer-dependencies?

jscheid commented 4 years ago

I have one question about these version strings.

https://github.com/jscheid/prettier.el/blob/b315e2ed721c46f6b42d3d543e6d438536469b2c/prettier.el#L172

When do we need to update the strings in accordance with the prettier version in each plugin's dependencies or peer-dependencies?

Good question. The one you quoted (Angular) is actually a core plugin that was added to Prettier in version 1.15, so in this case the version information won't change (unless they remove support one day). But your question still holds for external plugins, one could drop support for an older Prettier version at any time.

Then again, people are still free to use an older version of the plugin, so technically the minimum Prettier version won't change here either.

In any case, even if some of the version information (which I thought we'd provide as a courtesy) was flat out wrong, I don't think much harm will be done. Worst case, if someone gets bitten by an inaccuracy they can point it out and we'd update it. Would you agree?

If you think it better to remove the version info altogether and let people work it out themselves, I wouldn't be opposed to that either.

jscheid commented 4 years ago

On second thought, perhaps it would be good to drop the version info for external plugins and keep it for internal ones, since for those it is essential information: the only way to get support for an input type such as Angular is to upgrade to a Prettier version that supports it.

asbish commented 4 years ago

Thank you for your detailed explanations. I agree with your first thought. If we get issues or some versions regarding external plugins become uncertain, it would be better to remove them in accordance with your second thought. Thanks again!