search

jscheid / prettier.el

Prettier code formatting for Emacs.
GNU General Public License v3.0
168 stars 12 forks source link

Add continuous deployment #25

Closed jscheid closed 4 years ago

jscheid commented 4 years ago

Also, bump version to 0.9.0.

Closes #11

wyuenho commented 4 years ago

Why are you still building tar balls, instructing users to install via Quelpa instead of Melpa, and deleted the lock file?

jscheid commented 4 years ago
  1. Because they let myself and others test PRs easily, as described in RELEASING.md. If you mean the release tarball, it can't hurt to have a secondary source for installation/reference, uploading is 10 LOC.
  2. Because it's not on Melpa yet, getting it on there is a separate step after which the instructions can be removed obviously.
  3. I don't want to have to worry about keeping two lock files in sync, one is enough. I prefer yarn personally but that would be an extra dependency to install in CI, npm will do just fine.
wyuenho commented 4 years ago

Sounds reasonable

jscheid commented 4 years ago

Thanks for the review @wyuenho.

@asbish @aspiers any concerns or suggestions from your side? If there aren't any, I'll merge and then, in the not too distant future, submit a PR against MELPA - next weekend perhaps.

aspiers commented 4 years ago

Sorry I didn't have time to review, but very happy you are making progress with this! :+1: