jscheid / prettier.el

Prettier code formatting for Emacs.
GNU General Public License v3.0
168 stars 12 forks source link

.prettierignore file content is ignored. #67

Closed farynaio closed 3 years ago

farynaio commented 3 years ago

Is your feature request related to a problem? Please describe. Project specific .prettierignore file content is ignored. It makes impossible to keep formatting consistency when .prettierignore is provided and used by the rest of the team.

Describe the solution you'd like .prettierignore file content will be used to decide if file should be included or ignored by Prettier formatter.

Describe alternatives you've considered don't know any

Additional context none

jscheid commented 3 years ago

Good catch @farynaio. I'm going to dogfood the fix for a few days before releasing it. If you'd like to use it sooner, you can download the tarball from here and install it with M-x package-install-file (you have to peel off the zip layer but not the tar layer.)

jdelStrother commented 2 years ago

Did this ever get released? I'd like to try the tarball, but it seems to have expired.

jscheid commented 2 years ago

Yes, it did get released. Does it not work for you?

jdelStrother commented 2 years ago

I was actually having a problem where it wasn't locating .prettierrc that sounded like it might be related, but that turned out to be fixed by a prettier-restart - sorry for the noise.

(I was also confused by not finding the fixed commit in https://github.com/jscheid/prettier.el/commits/v1.1.0, but it looks like melpa has a more recent release)

jscheid commented 2 years ago

Ah right, it's not in stable. I should probably cut a new release, thanks for the heads up.