search

jscher2000 / Save-webP-as-extension

Firefox extension to overlay format and JPEG quality buttons on inline or stand-alone images for quickly saving a converted version of the image.
Mozilla Public License 2.0
32 stars 1 forks source link

Auto-open settings not functional #26

Closed Hexerin closed 2 months ago

Hexerin commented 9 months ago

593ec3c67384e3691823829cb2584bc1

These settings aren't working. No matter what combo of these I set, the plugin automatically opens the overlay on every image regardless.

d8492f78e6347ade89dc97cf59e28082

The auto-close setting does work, however.

jscher2000 commented 9 months ago

I can't think of a logical reason for that. One possibility is that the add-on preference storage somehow got corrupted so what you see on the Options page is not really what is stored. Maybe.

You can clear the add-on preference storage this way:

(1) Open about:debugging and in the left column, click This Firefox

(2) Find this add-on and click the Inspect button

(3) In the pop-up debugging console, switch to the Storage tab and expand Extension Storage

(4) Right-click prefs and delete it -- after that, you might need to disable and re-enable the extension to flush it from memory (I'm not sure how long it is retained in memory)

Extension-debugger-Storage-context-menu

Hexerin commented 9 months ago

That fixed the issue, it would appear. However, this happened immediately off of a completely fresh install. I've never used this addon before, on this device or otherwise. Might be worth looking into how the addon generates the default settings on install?

beefjerky9 commented 7 months ago

I'd like to add here that I also had this issue after a fresh install on Firefox. Deleting the prefs did fix the issue, but it doesn't make much sense for this to happen on a new install.

jscher2000 commented 7 months ago

I found the source of this problem, but I'm not sure why it is occurring.

When you turn off the automatic bar and save the change, a script runs that unregisters the content script that detects stand-alone pages. That seems to have stopped working in September for some reason (i.e., there was a change in Firefox that I either didn't notice or failed to understand).

As a fix, I am adding code to check the automatic bar preference a second time. I haven't decided whether to push this tiny change now or wait until I can add some more features.

jscher2000 commented 7 months ago

I uploaded version 1.4 for review with the bug fix. The main change is a new Copy to Clipboard button.

jscher2000 commented 2 months ago

Since there haven't been any new reports of this somewhat rare problem, I'll go ahead and close this issue as probably fixed.