jscher2000 / Show-History-Frequent-Sites-button-extension

Replacement for Firefox "Show History" button to list frequent sites.
Mozilla Public License 2.0
3 stars 0 forks source link

A request, not an issue :) #6

Open mimteatr opened 4 years ago

mimteatr commented 4 years ago

Hello,

Thanks for this add-on!

Is it possible to move it to inside the Address Bar? I've tried through the Customize option and it doesn't work.

Thanks in advance,

Maurice Rosenthal

jscher2000 commented 4 years ago

Hi Maurice, I can't move the list into the address bar drop-down, but I could put the button in the Page Actions area (where you find Bookmark This Page).

When I looked at it originally, the Page Actions area disappeared when the cursor moved into the address bar. However, in Firefox 78+, if you turn off the option under

Options/Preferences > Privacy & Security > Address Bar > [_] Top Sites

that problem is resolved.

So now I need to figure out how to provide a choice, if that is possible.

mimteatr commented 4 years ago

Hi Jefferson, actually I meant the Page Actions from the beginning but if I understood you correctly you WILL create a button? I have FF 82 and still nothing shows in the Page Actions after unchecking the Top Sites option.

Cheers,

Maurice Rosenthal +972-52-4533701

On Wed, Oct 14, 2020, 20:40 Jefferson Scher notifications@github.com wrote:

Hi Maurice, I can't move the list into the address bar drop-down, but I could put the button in the Page Actions area (where you find Bookmark This Page).

When I looked at it originally, the Page Actions area disappeared when the cursor moved into the address bar. However, in Firefox 78+, if you turn off the option under

Options/Preferences > Privacy & Security > Address Bar > [_] Top Sites

that problem is resolved.

So now I need to figure out how to provide a choice, if that is possible.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jscher2000/Show-History-Frequent-Sites-button-extension/issues/6#issuecomment-708555202, or unsubscribe https://github.com/notifications/unsubscribe-auth/AITIDVKWM2MBBP2JWC4TU7TSKXO77ANCNFSM4SQP7SBA .

jscher2000 commented 4 years ago

Okay, I tested a change. Firefox allows having both a button on the main toolbar and on the Page Actions menu. However, I can't use the Page Actions menu on a new tab, only on a tab with a page loaded (there is a URL in the bar), so that's a problem.

Using a custom style rule in userChrome.css, I can force the menu to be visible, but the page action added by the extension is grayed out. I think this is because the page is about:newtab and that is not a valid scope for an extension page action.

Based on this test, I don't think it will be very helpful to have this option, but I think there's no harm in adding it for those situations in which it might be useful.

mimteatr commented 4 years ago

Thank you for your efforts! Cheers, Maurice

Maurice Rosenthal +972-52-4533701

On Sat, Oct 17, 2020, 05:21 Jefferson Scher notifications@github.com wrote:

Okay, I tested a change. Firefox allows having both a button on the main toolbar and on the Page Actions menu. However, I can't use the Page Actions menu on a new tab, only on a tab with a page loaded (there is a URL in the bar), so that's a problem.

Using a custom style rule in userChrome.css, I can force the menu to be visible, but the page action added by the extension is grayed out. I think this is because the page is about:newtab and that is not a valid scope for an extension page action.

Based on this test, I don't think it will be very helpful to have this option, but I think there's no harm in adding it for those situations in which it might be useful.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jscher2000/Show-History-Frequent-Sites-button-extension/issues/6#issuecomment-710728789, or unsubscribe https://github.com/notifications/unsubscribe-auth/AITIDVNE2DNSB4V6DDWJHKLSLD5SDANCNFSM4SQP7SBA .