search

jscher2000 / switch-to-previous-active-tab

Firefox toolbar button to switch to the last accessed tab (and MRU popup)
Mozilla Public License 2.0
8 stars 1 forks source link

Does not work correctly under certain circumstances #10

Closed sakkamade closed 2 years ago

sakkamade commented 2 years ago

This is awfully specific issue, so I'll try to walk you through it step by step.

Steps to reproduce

Conditions:

  1. Firefox is closed
  2. I click the link in external application which calls Firefox to open it

So, when I do that with version 1.9.6, it is like so:

  1. New tab with that link opens at the very end
  2. Calling the action "Switch to previous active tab" by assigned shortcut would switch browser to the tab that I closed it with

Problem

However, with version 2.0 and 2.0.1 at the step 4 I am being guided to the pinned tab.

Other information

OS: Arch Linux

sakkamade commented 2 years ago

However, with version 2.0 and 2.0.1 at the step 4 I am being guided to the pinned tab.

And if I don't have pinned tabs, the shortcut does nothing at all.

jscher2000 commented 2 years ago

Hi, I suspect this is because of the new setting to skip unloaded tabs. Because Firefox launched from an external link, the last tab was not loaded (it is still pending/discarded). However, pinned tabs are always loaded.

Try unchecking the box for this feature (second one):

Options

sakkamade commented 2 years ago

Hello.

Whoa! Never knew this add-on had settings! Hahahaha.

(Have been using it for several years...)

sakkamade commented 2 years ago

Try unchecking the box for this feature (second one):

Unchecking "Button/key skips unloaded tabs" didn't help.

jscher2000 commented 2 years ago

You can tell I'm not a professional developer... I missed the fact that user preferences take time to retrieve, so the lists were being built too early based on default settings. I think I've fixed it in version 2.0.2.

sakkamade commented 2 years ago

I think I've fixed it in version 2.0.2.

Yes, it is fixed. Thank you very much! :heart:

Perhaps settings window can be added somewhere else as well, so to be accessible from about:addons page too?

  1. As the entry of add-on's three-dot menu which will open a "New tab" with settings? (GlitterDrag does that.)
  2. Directly as a tab of the add-on page—between "Details" and "Permissions"?

Should I open a separate issue about it?

jscher2000 commented 2 years ago

There isn't any perfect way to do Options as far as I'm concerned... You can open a separate issue.