search

jscher2000 / switch-to-previous-active-tab

Firefox toolbar button to switch to the last accessed tab (and MRU popup)
Mozilla Public License 2.0
8 stars 1 forks source link

Popup doesn't close itself after update to v2.2 #12

Closed mystiquewolf closed 2 years ago

mystiquewolf commented 2 years ago

I have the option Keep list open in same window unchecked. After the last update to v2.2 switching to a different tab (by clicking on its entry in the popup) no longer causes the popup to close itself automatically.

Stack trace:

Uncaught (in promise) TypeError: self.close is not a function
    gotoTab moz-extension://d4d50315-15f4-41c2-89a8-cebd1282b8ce/popup.js:464
    promise callback*gotoTab/< moz-extension://d4d50315-15f4-41c2-89a8-cebd1282b8ce/popup.js:455
    promise callback*gotoTab moz-extension://d4d50315-15f4-41c2-89a8-cebd1282b8ce/popup.js:454
    EventListener.handleEvent* moz-extension://d4d50315-15f4-41c2-89a8-cebd1282b8ce/popup.js:481
popup.js:464:11

I believe the issue is the addition of the self variable HERE, which returns string and causes THIS to fail.

jscher2000 commented 2 years ago

Thank you, I should try not to code after 10pm. The fix should go live soon.

mystiquewolf commented 2 years ago

Yeah, been there, done that... :slightly_frowning_face: