Summary

[ghost]

Satisfactory 👍

You've written some great code here. You've demonstrated an exceptional understanding of the material and have applied it with a great sense of efficiency.

One issue I found is that your project has several dependencies (express, errorhandler, cors, etc.) that are not listed in your package.json file. This results in a very inconvenient experience for someone else running your code. Make sure you run npm install --save [packages] when you're installing your application's dependencies, that way they'll get saved in the package.json file and someone downloading your code will be able to install everything in a single try.

[jscherff]

Hello, and thank you for your great feedback!

In response to the issue you mentioned regarding "package.json:"

I uploaded only the original pristine copy of the project from Codecademy to GitHub -- along with my custom source files -- because running "npm install" makes the project too large for my GitHub account. This is due to all the files that get installed in the "node_modules" directory, which was 41MB and contained 12,318 files and 1,654 folders!

What I did instead, as a compromise, was include a "setup.sh" script which installs dependencies required by my project and also creates the database. You can find the setup script here.

In hindsight, I realize should have just updated the package.json file and added that to the pristine copy of the project. Alternatively, I could have added a .git_ignore file to exclude the node_modules directory.

Thoughts?

[jscherff]

Hi Steve. I left the following as a comment in GitHub but thought I'd follow up with an email as well:

Hello, and thank you for your great feedback!

In response to the issue you mentioned regarding "package.json:"

I uploaded only the original pristine copy of the project from Codecademy to GitHub -- along with my custom source files -- because running "npm install" makes the project too large for my GitHub account. This is due to all the files that get installed in the "node_modules" directory, which was 41MB and contained 12,318 files and 1,654 folders!

What I did instead, as a compromise, was include a "setup.sh" script which installs dependencies required by my project and also creates the database. You can find the setup script here https://github.com/jscherff/expresso/blob/master/setup.sh.

In hindsight, I realize should have just updated the package.json file and added that to the pristine copy of the project. Alternatively, I could have added a .git_ignore file to exclude the node_modules directory.

Thoughts?

On Thu, Mar 29, 2018 at 11:39 AM, Steve Toro notifications@github.com wrote:

Satisfactory 👍

You've written some great code here. You've demonstrated an exceptional understanding of the material and have applied it with a great sense of efficiency.

One issue I found is that your project has several dependencies (express, errorhandler, cors, etc.) that are not listed in your package.json file. This results in a very inconvenient experience for someone else running your code. Make sure you run npm install --save [packages] when you're installing your application's dependencies, that way they'll get saved in the package.json file and someone downloading your code will be able to install everything in a single try.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jscherff/expresso/issues/4, or mute the thread https://github.com/notifications/unsubscribe-auth/ABwHbum-2VvqAqMr4xgCAeb3D3zHvJnlks5tjSpugaJpZM4TAy7y .