jschiefner / advanced-brightness-slider-tweak

iOS Tweak that manipulates the brightness slider in the control center so the display brightness and the white point intensity can be modified
https://havoc.app/package/advancedbright
GNU General Public License v3.0
29 stars 6 forks source link

Not working #1

Closed harpreet009 closed 3 years ago

harpreet009 commented 3 years ago

Not working on iPhone XS Max iOS 14.3. tweaks do nothing please fix this, because this is very good tweak I love the concept. Thanks you for putting effort to create this tweak.

BranGao commented 3 years ago

Me too, doesn’t work on XsMax iOS14.1 My eyes can finally get rid of PWM. Love this concept so much.

jschiefner commented 3 years ago

Hi thanks to both of you reporting this issue and your kind words! I really want this to work for everyone, unfortunately i only have a single device i can test this on but i'll try everything to make it work for you. Would you mind checking in the settings app if the tweak is set to enabled? Or if the preferences for AdvancedBrightnessSlider even load? That should give at least a small hint at to what could be the problem. If the preference bundle loads correctly, maybe drag the brightness slider down completely and check if the reduce white point option in the Accessibility settings turned on or not for now. I will ask around if there are people who can test the tweak and supply the error message to me so i can work with that. Does either of you have a mac? There is an easy way to extract Log messages from the iPhone, allowing me to understand why the tweak is not working.

jschiefner commented 3 years ago

Other devs helped me figure out the issue actually. I forgot to properly initialize the preferences, making the tweak think it was disabled by the user after installing it. It would be great if you could update the tweak to version 0.1.1 and report back if that fixes your issue 🙏🏼

BranGao commented 3 years ago

Thank you, it just works like magic. Problem solved🙏

发自我的iPhone

在 2021年9月19日,上午1:18,Jonas Schiefner @.***> 写道:

 Other devs helped me figure out the issue actually. I forgot to properly initialize the preferences, making the tweak think it was disabled by the user after installing it. It would be great if you could update the tweak to version 0.1.1 and report back if that fixes your issue 🙏🏼

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

jschiefner commented 3 years ago

Love to hear it 😊 thanks again to both of you for reporting this, without this issue i probably wouldn't have realised for a while. Enjoy the tweak and if there is anything else let me know!

harpreet009 commented 3 years ago

Yeah, thanks you so much. It’s working great now. I would love to have more tweaks made by you like this.

harpreet009 commented 3 years ago

Can you make a tweak ( just a idea) keep music playing through respring, other tweaks not work properly or create errors with music app after respring.

jschiefner commented 3 years ago

Thanks for your compliment! 😊 That sounds like a great idea, i doubt that this would be possible sadly, because tweaks are stopped and restarted upon a respring. To my understanding this makes it impossible for code that is injected into iOS continuously running during a respring unfortunately. You could head over to r/jailbreak or r/tweakbounty and see if someone is up for the task!

rastafaa commented 3 years ago

Can you make a tweak ( just a idea) keep music playing through respring, other tweaks not work properly or create errors with music app after respring.

There’s a tweak that does that already. I don’t currently use it but it worked perfectly when I tried it in the past. I think it was Resume tweak made by smokin1337

jschiefner commented 3 years ago

@harpreet009 i just saw theres another tweak doing what you asked for: https://www.ios-repo-updates.com/repository/henrikssonbrothers/package/se.nosskirneh.roadrunner/