search

jschiefner / advanced-brightness-slider-tweak

iOS Tweak that manipulates the brightness slider in the control center so the display brightness and the white point intensity can be modified
https://havoc.app/package/advancedbright
GNU General Public License v3.0
29 stars 6 forks source link

Using this toggles auto brightness on #4

Open nhowardmit opened 3 years ago

nhowardmit commented 3 years ago

Turn auto brightness off Dim via this tweak Undim via this tweak Auto brightness gets toggled on User gets the sads

jschiefner commented 3 years ago

fright not, here's how to change that: toggle "modify auto-brightness" off in the AdvancedBrightnessSlider tweak preferences. Then toggle off Auto-Brightness in the accessibility settings one last time. The tweak should then stop adjusting the auto-brightness setting.

nhowardmit commented 3 years ago

Ok, then we disagree on bug vs feature.

I would contend that the default behaviour should be: after turning a tweak on then off all adjusted settings should go back to how they were.

For this tweak it is highly advised autobrightness be off while it is activated, but when it is deactivated that setting is immaterial.

Therefor the default behaviour should be:

On activate, if autobrightness=on and leaveautobrightnessalone=off:

            Set autobrightness=off

            Set autobrightnesstoggled=True

On deactivate, if autobrightnesstoggled=True and leaveautobrightnessalone=off:

            Set autobrightness=on

            Set autobrightnesstoggled=False

The leaveautobrightnessalone setting should only come into play if the user, against advice, wants autobrightness on despite the tweak being activated.

From: Jonas Schiefner @.> Sent: Thursday, October 7, 2021 6:01 AM To: jschiefner/advanced-brightness-slider-tweak @.> Cc: nhowardmit @.>; Author @.> Subject: Re: [jschiefner/advanced-brightness-slider-tweak] Using this toggles auto brightness on (#4)

fright not, here's how to change that: toggle "modify auto-brightness" off in the AdvancedBrightnessSlider tweak preferences. Then toggle off Auto-Brightness in the accessibility settings one last time. The tweak should then stop adjusting the auto-brightness setting.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jschiefner/advanced-brightness-slider-tweak/issues/4#issuecomment-937641684 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ATAGTDNOFOEXPFO66W7OBLDUFVVWHANCNFSM5FQC6EIQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub . https://github.com/notifications/beacon/ATAGTDKBQIEWVQBBQ3FSCQ3UFVVWHA5CNFSM5FQC6EI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOG7RUNVA.gif

jschiefner commented 3 years ago

I don't disagree actually, i've read multiple comments where people were confused about this behaviour, i will look into it and change that in the next release. Thanks for your suggestions!

jschiefner commented 2 years ago

Hey, i made a new release (v1.1.0) to address this issue. I hope the Auto-Brightness toggling is less intrusive now, would you mind giving me your thoughts on the new release?

nhowardmit commented 2 years ago

Finally got around to installing (and reinstalling...) and...

Sent from my iPhone

On Dec 22, 2021, at 7:16 PM, Jonas Schiefner @.***> wrote:

 Hey, i made a new release (v1.1.0) to address this issue. I hope the Auto-Brightness toggling is less intrusive now, would you mind giving me your thoughts on the new release?

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.

nhowardmit commented 2 years ago

Appears screenshot doesn’t make it onto here...

after upgrade no longer works

Opening settings generates an error:

AdvancedBrightnessSliderPreferences: stat() failed with error=45

“ReinstallEd” and got same error

removed, installed again, still same error

jschiefner commented 2 years ago

Normally you should be able to upload screenshots here. Where does this error appear exactly, in the preference pane of the tweak?

nhowardmit commented 2 years ago

Yes. Tweak is off. Open preferences and get that error. I can type up the trace back if need be

Sent from my iPhone

On Jan 5, 2022, at 5:20 PM, Jonas Schiefner @.***> wrote:

 Normally you should be able to upload screenshots here. Where does this error appear exactly, in the preference pane of the tweak?

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.

nhowardmit commented 2 years ago

Note: Iphone SE(2) iOS 13.5

jschiefner commented 2 years ago

Hey, it seems like something changed in the Build System when i got a new MacBook. Could you to install those two .deb files manually and tell me if one or both work? I packed them up in a .zip file here:

Archive.zip

Installation instructions can be found here: https://idisqus.com/how-to-install-deb-files-ios-14-with-filza/

nhowardmit commented 2 years ago

I installed 11.0.3 and it works again

Sent from my iPhone

On Jan 11, 2022, at 1:16 PM, Jonas Schiefner @.***> wrote:

 Hey, it seems like something changed in the Build System when i got a new MacBook. Could you to install those two .deb files manually and tell me if one or both work? I packed them up in a .zip file here:

Archive.zip

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.

jschiefner commented 2 years ago

Could you try the following versions as well? These are compiled with a M1 Macbook which i will use from now on to release so it is crucial that they work as well.

advancedbrightnessslider_1.1.0_m1_macbook_older_xcode_versions.zip

jiyangzwb commented 2 years ago

关闭了AdvancedBrightnessSlider ， 手机自动调节亮度不能正常运行，根据环境光源。

jiyangzwb commented 2 years ago

If turned off or uninstalled, the phone's automatic brightness adjustment function based on ambient light will not resume

jschiefner commented 2 years ago

@jiyangzwb can you specify what you tried to do, what you expected to happen and what happened instead?

shMatrix commented 2 years ago

Hello @jschiefner Thank you a lot for this really great tweak. I would like to share with you my suggestions how your tweak can be improved more if you don't mind of cource. THB, currently I don't understand the logic of using auto brightness while adjusting brightness via your tweak: sometimes auto brightness starts to work right away once I increased or decreased brightness, sometimes not (i'm not talking about reduced white point range now). I would suggest to make it more clearly for example in that way: Once brightness was adjusted via your tweak auto brightness mode should be completely disabled till user turns it on himself. And it could be cool to implement option like - "force auto brightness" directly in CC when it's needed, for example by touching the "sun icon" in brightness bar or in any other way. I understand that forcing auto brightness mode in reduced white point range could lead to unpredictable behavior, in that case I would suggest to implement logic\script like - once auto brightness was forced then tweak should disable "reduce white point" mode and force normal auto brightness mode. What do you think?

jschiefner commented 2 years ago

Hi @shMatrix thank you so much for your thoughts, i greatly appreciate people taking interest in the tweak in this way 😊

I'm not too happy myself how this feature works but right now i don't have the time to work on this tweak. But I wanted to overhaul this feature for some time and add some kind of button like you suggested. I was gonna add it next to the "True Tone" button as a fourth one and maybe make that optional of some kind. When i have time again for this project i will for sure take your comment into consideration!