jschlatow / taskopen

Tool for taking notes and open urls with taskwarrior
GNU General Public License v2.0
364 stars 31 forks source link

Fix makefile #106

Closed Nicop06 closed 7 years ago

Nicop06 commented 7 years ago

This will avoid problems when building with make -jN. In fact, in that case, the clean action was executed at the same time that the manfiles action, so the files could be removed before being installed, leading to failed installation. For instance, with make -j2, I have:

rm -f taskopen.pl
gzip -c doc/man/taskopen.1 > doc/man/taskopen.1.gz
rm -f doc/man/taskopen.1.gz
rm -f doc/man/taskopenrc.5.gz
gzip -c doc/man/taskopenrc.5 > doc/man/taskopenrc.5.gz
sed s',#PATH_EXT=.*,&\nPATH_EXT=/share/taskopen/scripts,' taskopen > taskopen.pl

If you still want to clean before rebuild, I did an alternative fix available in my fix-makefile-alternative branch. I can merge it in this pull request.

Also, I noticed this error after creating a portage package for my Gentoo laptop. I might also create a Debian / Ubuntu for my other laptop. If you are interested, I can share them with you or publish them.