Fix warnings - Githubissues

jschniper / gelf_logger

An Elixir Logger backend for GELF

MIT License

29 stars 27 forks source link

Fix warnings #18

Closed flowerett closed 6 years ago

flowerett commented 6 years ago

Hello, currently, gelf_logger has a lot of deprecation warnings, so here's a suggestion how to fix it.

Main things that were changed:

GenEvent replaced with erlang's :gen_event
Poison replaced with Jason
added a default mix formatter

Unfortunately, Jason doesn't support Elixir 1.2 so I've dropped that dependency.

Looking forward to any feedback.

jschniper commented 6 years ago

Instead of making a hard switch to Jason, I think I'm going to go back and make that a configuration option similar to how the Plug.Parsers module handles it.

flowerett commented 6 years ago

Should I add this additional configuration in this PR or just revert back to Poison?

jschniper commented 6 years ago

No, I should be able to just make some quick changes to the work you've already done. Thank you for all of your help.

jschniper commented 6 years ago

I rebased your commits in order to clean up the history a bit as well as to make the JSON encoder configurable. I've tagged the new release as 0.8.0 but I haven't released it to hex as of yet. I'll take care of that either later today or sometime early next week.

Again, thanks for all of your help.