search

jschr / bootstrap-modal

Extends the default Bootstrap Modal class. Responsive, stackable, ajax and more.
http://jschr.github.io/bootstrap-modal/
Apache License 2.0
5k stars 1.09k forks source link

Not working with the Bootstrap-Image-Gallery gem #71

Open cameronkendall opened 11 years ago

cameronkendall commented 11 years ago

Prior to using bootstrap-modal, I was able to use the Bootstrap-Image-Gallery (https://github.com/blueimp/Bootstrap-Image-Gallery), which adds the ability to show gallery images in a bootstrap modal. The images don't show up anymore in the modal. No errors are produced so I don't know how to debug this issue. Any thoughts on what might be happening to cause this issue? Thanks

jschr commented 11 years ago

Can you try with the latest version? I just accepted a pull request that fixes some issues with event propagation that could be the cause. Otherwise if you have a test page of jsfiddle of the issue I'd be glad to take a look.

cameronkendall commented 11 years ago

Thanks for getting back so quick. I tried the most recent version of bootstrap-modal and it is still not working. Here are the jsfiddles (please note I've included the the css for both the Bootstrap-Image-Gallery and bootstrap-modal in the css section. It wasn't recognizing it if I included them in the Manage Resources section): Without bootstrap-modal: http://jsfiddle.net/3ff3z/11/ With bootstrap-modal: http://jsfiddle.net/3ff3z/12/

jschr commented 11 years ago

Both fiddles seems to work for me or am I missing something?

http://i.imgur.com/3Qn4tW2.png http://i.imgur.com/e1t5umS.png

cameronkendall commented 11 years ago

Sorry, I should have described it better. You need to actually click on the image in the modal to see what I am talking about. jsfiddle 11 is working correctly because the image is actually loaded whereas in 12 the images are never loaded. The demo page is here - http://blueimp.github.com/Bootstrap-Image-Gallery/

jschr commented 11 years ago

Ah ok I see the issue now. Looks like a I might have to dig into their code to find out why it's not working. Hopefully there is something I can do. Will try to figure this out asap.

pierre-dickinson commented 9 years ago

I, i've integrated your plugin in my wp theme (based on the roots.io theme) and it works. but i've got an issue when the modal is displaying, i get 2 empty modals inserted in my third one! here is a screenshot : GitHub Logo Format: ![modal issue 3 modals(http://www.mecanographik.fr/wp-content/uploads/bootstrap-image-agallery-modal-issue.png) i don't use js to trigger the gallery, only the data-gallery markup

When i click on a thumb to load the pict, the second modal is inserted in the

Please help!

pierre-dickinson commented 9 years ago

it's ok i've find the bug, and it wasn't your plugin, sorry. It was an issue with my grunt.js and the way the plugin's js was compiled in a global file called scripts.js. The plugin's js file was called 3 times in my theme! if you want to create a wordpress plugin of your bootstrap-modal i've got the scripts!