search

jschr / electron-react-redux-boilerplate

A minimal boilerplate to get started with Electron, React and Redux.
556 stars 130 forks source link

Browser-sync breaking change #43

Closed pronebird closed 6 years ago

pronebird commented 6 years ago

It seems that browser-sync@2.21 was the last version shipped with lib folder and we do import browser-sync/lib/connect-utils from it. I think changing lib -> dist should do the trick.

Compare

  1. https://unpkg.com/browser-sync@2.21.0/
  2. https://unpkg.com/browser-sync@2.23.6/
phoenixrip commented 6 years ago

This was useful to me. lib vs dist caused an error on my first npm start, but changing import browserSyncConnectUtils from 'browser-sync/lib/connect-utils'; to import browserSyncConnectUtils from 'browser-sync/dist/connect-utils';
in scripts/serve.js instantly fixed the problem!

jschr commented 6 years ago

Awesome! @phoenixrip happy to accept the PR if you have a fix. Otherwise I'll get to this ASAP.

vicesalles commented 6 years ago

Hi, running npm install I got installed the "browser-sync": "^2.9.3" and browserSyncConnectUtils was throwing an error so I changed the serve file back to lib and it works. dist-> lib. Not sure if somebody else have had the same problem.

Cheers.

jschr commented 6 years ago

Looks like we may have forgotten to bump the browsersync version number in https://github.com/jschr/electron-react-redux-boilerplate/pull/44 to ^2.23.6.

@vicesalles If you could confirm that also fixes it that would be appreciated!

vicesalles commented 6 years ago

if I update the version of browsersync to 2.23.6 the original code works fine. But with the default 2.9.3 version it crashes.

jschr commented 6 years ago

Great, thanks for confirming. Fixed in https://github.com/jschr/electron-react-redux-boilerplate/pull/45