jschuh / klipper-macros

A collection of useful macros for the Klipper 3D printer firmware
GNU General Public License v3.0
921 stars 167 forks source link

Checking for extruder instead of heater in temperature menus #199

Closed KRTac closed 9 months ago

KRTac commented 10 months ago

Hi

When there's a chamber section in the menu temps, the gcode of preheat all checks for an extruder in the printer object, instead of heater_generic chamber. Example

Stops preheat from triggering if there's no chamber heater present, like on my printer.

jschuh commented 10 months ago

Oh yeah, that's a bug, but I can't imagine how it could stop the preheat from triggering. The only effect it should have is to allow setting a chamber temps from the menu when no chamber heater is actually configured.

KRTac commented 10 months ago

I use chamber temp settings and don't have an active heater setup, only a temperature_sensor chamber that is referenced in a custom macro. That's also why the chamber temp doesn't get forwarded to KM's PRINT_START macros, because there is no heater to actually activate.

jschuh commented 9 months ago

Should now be fixed in 088b4d0.