jschuh / klipper-macros

A collection of useful macros for the Klipper 3D printer firmware
GNU General Public License v3.0
972 stars 172 forks source link

Upcoming klipper changes for bed mesh #30

Closed HitLuca closed 1 year ago

HitLuca commented 1 year ago

Just a heads up for the upcoming changes in klipper regarding bed mesh, here is the message as displayed on mainsail:

Klipper changes to [bed_mesh] module In an upcoming change to Klipper, the default bed_mesh configuration will no longer be automatically loaded at startup. If you are using a bed_mesh configuration today then it is recommended to add an explicit BED_MESH_PROFILE LOAD=default command to your START_PRINT macro (or equivalent print start commands in your slicer). This change to Klipper is planned for February 1st 2023.

link to the klipper announcement

Not sure if it also applies to adaptive bed mesh, but better safe than sorry!

jschuh commented 1 year ago

Yep, saw that. I don't think it will be an issue, since the bed mesh macros are profile agnostic and just passthrough any additional arguments. If anything, I think this change will be entirely positive, since I've been bitten by accidentally saving a profile as a default (e.g. after a PID tune) and then having it automatically applied at startup.

That stated, I'll keep my eyes open to make sure the change is compatible.

flow23 commented 1 year ago

Hi, as far as I can see there is no explicit load of the bed mesh in your macros.

jschuh commented 1 year ago

Yep, as I mentioned above the bed mesh macros are profile agnostic, because they just re-probe on each print (unless disabled by setting variable_start_level_bed_at_temp: 0). That stated, if one wanted to have a profile applied at startup they could just add something like BED_MESH_PROFILE LOAD=default to the gcode section of [gcode_macro _km_options].

jschuh commented 1 year ago

Figured I'd circle back and leave some notes here. Looking at Arksine's PR, he's changing only the profile loading behavior at Klipper initialization. Whereas this is the part of the code that sets the default value of the PROFILE argument in BED_MESH_CALIBRATE.

So, it doesn't seem like there's anything that needs to change in these macros (at least not for the PR associated with the notification).