Closed HitLuca closed 1 year ago
Yep, saw that. I don't think it will be an issue, since the bed mesh macros are profile agnostic and just passthrough any additional arguments. If anything, I think this change will be entirely positive, since I've been bitten by accidentally saving a profile as a default (e.g. after a PID tune) and then having it automatically applied at startup.
That stated, I'll keep my eyes open to make sure the change is compatible.
Hi, as far as I can see there is no explicit load of the bed mesh in your macros.
Yep, as I mentioned above the bed mesh macros are profile agnostic, because they just re-probe on each print (unless disabled by setting variable_start_level_bed_at_temp: 0
). That stated, if one wanted to have a profile applied at startup they could just add something like BED_MESH_PROFILE LOAD=default
to the gcode
section of [gcode_macro _km_options]
.
Figured I'd circle back and leave some notes here. Looking at Arksine's PR, he's changing only the profile loading behavior at Klipper initialization. Whereas this is the part of the code that sets the default value of the PROFILE
argument in BED_MESH_CALIBRATE
.
So, it doesn't seem like there's anything that needs to change in these macros (at least not for the PR associated with the notification).
Just a heads up for the upcoming changes in klipper regarding bed mesh, here is the message as displayed on mainsail:
link to the klipper announcement
Not sure if it also applies to adaptive bed mesh, but better safe than sorry!