search

jschuh / klipper-macros

A collection of useful macros for the Klipper 3D printer firmware
GNU General Public License v3.0
972 stars 172 forks source link

Mistake in providet "add to moonraker.conf" #57

Closed DragonPerl closed 1 year ago

DragonPerl commented 1 year ago

I copied the code as in the box and pasted it to my moonraker.conf. The Button showed me an error.

To solve the problem i simply switched the lines "path: ..." and "origin: ...", as the rest of the configs where written like this.

''' [update_manager klipper-macros] type: git_repo path: ~/printer_data/config/klipper-macros # UPDATE THIS FOR YOUR PATH!!! origin: https://github.com/jschuh/klipper-macros.git primary_branch: main is_system_service: False managed_services: klipper '''

Now everything's ok.

Thanks for your awesome work, try to figure out all of the functionality! Greetings from Austria! Markus

jschuh commented 1 year ago

Glad you were able to get your issue sorted, but I can't imagine that is had anything to do with the order of these fields. All my machines actually have configs identical to the readme, and I've seen many other installs successfully using it.

More importantly, if you look at Moonraker's confighelper you'll see that it parses the full config set using python's configparser library and performs variable expansion of Jinja2 templates before handing off a synthesized dict of the config to any modules. So, as the code is currently written it's literally impossible for any submodules (including UpdateManager) to even know the order of config fields in the file, much less have a dependency on them.