search

jscottsmith / react-scroll-parallax

🔮 React hooks and components to create parallax scroll effects for banners, images or any other DOM elements.
https://react-scroll-parallax.damnthat.tv/
MIT License
2.9k stars 158 forks source link

fix: add children to parallax provider type #198

Closed geongeorge closed 1 year ago

geongeorge commented 1 year ago

ParallaxProvider component does not accept children when props are provided.

Fixes this: https://github.com/jscottsmith/react-scroll-parallax/issues/194

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-scroll-parallax ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2023 5:28am
codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (a61ca52) 85.65% compared to head (1834bc9) 85.65%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #198 +/- ## ======================================= Coverage 85.65% 85.65% ======================================= Files 19 19 Lines 237 237 Branches 51 51 ======================================= Hits 203 203 Misses 33 33 Partials 1 1 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=J+Scott+Smith). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=J+Scott+Smith)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.