jscraftcamp / website

Website of the JSCraftCamp in Munich
https://jscraftcamp.org
48 stars 387 forks source link

Add myself as a participant 2024 #1904

Closed HeeL closed 7 months ago

HeeL commented 7 months ago

I would like to register for JS CraftCamp.

netlify[bot] commented 7 months ago

Deploy Preview for jscraftcamp ready!

Name Link
Latest commit b659671a1ce6131f23adab22b1464c9225814d14
Latest deploy log https://app.netlify.com/sites/jscraftcamp/deploys/66265e72fdf9ad0008024cb0
Deploy Preview https://deploy-preview-1904--jscraftcamp.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 84 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Narigo commented 7 months ago

Hi @HeeL, I'd like to merge your registration, but I was wondering whether you wanted to add your company to your PR as well, since you mentioned sharing "our" experiences.

Also, I guess I need to ask about tweet-of-god repository once we meet onsite 😅

HeeL commented 7 months ago

@Narigo hey, thanks for the quick reply and for the interesting talk on JS Meetup last week. Let's leave merge it like this if its ok, I've just skipped some optional fields when filling up the json

Narigo commented 7 months ago

Thanks! Sure we can merge it, looking forward to meeting you at the JSCC24!

Narigo commented 6 months ago

@HeeL sorry, I haven't noticed you had an underscore in front of the JSON, which we shouldn't have allowed in the first place. Our automated check didn't test your PR and after removing the underscore, the check failed because of the missing field githubAccountName. Please see https://github.com/jscraftcamp/website/pull/1953 and its log at https://github.com/jscraftcamp/website/actions/runs/8869852950/job/24350974069

I'm going to add "githubAccountName": "HeeL", after the realName field. If you want this to be different or have objections, please let me know - best place to comment would be in the PR fixing the underscores that I mentioned before (https://github.com/jscraftcamp/website/pull/1953)

HeeL commented 6 months ago

Looks good, many thanks 👍