Create harmeet_singh - Githubissues

harmeet24 commented 4 months ago

I would like to register for JS CraftCamp.

[x] My pull request contains a JSON file $name_or_nickname.json
[x] I read the THE IMPORTANT STUFF at https://jscraftcamp.org/registration, the JSON file follows the template, and contains the mandatory fields like realName, githubAccountName, when, iCanTakeNotesDuringSessions, whatIsMyConnectionToJavascript and whatCanIContribute.
[x] If I can NOT attend, I will either send another pull request removing my JSON file or an e-mail with the subject 'UNREGISTER' to team@jscraftcamp.org
[x] I agree that the data I enter in the registration can be used for running the event, e.g. make a name tag, count me as participant. I acknowledge that my data are public on GitHub and I agree that I will be listed on the JSCraftCamp website as a participant.
[x] I agree that photos and videos might be taken and published (e.g. on social media) during the event.
[x] I understand that I might NOT get a T-Shirt, because they might be in production already
[ ] I asked my company about sponsoring (see open items at: https://github.com/orgs/jscraftcamp/projects/7)

Are you from a sponsoring company?

netlify[bot] commented 4 months ago

Name	Link
Latest commit	6fa94d523f38d2cc1e31abddc585484cac3ce997
Latest deploy log	https://app.netlify.com/sites/jscraftcamp/deploys/664e4d0a55bf55000983e1c1
Deploy Preview	https://deploy-preview-2029--jscraftcamp.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 4 months ago

Name	Link
Latest commit	6fa94d523f38d2cc1e31abddc585484cac3ce997
Latest deploy log	https://app.netlify.com/sites/jscraftcamp/deploys/664e4d0a55bf55000983e1c1
Deploy Preview	https://deploy-preview-2029--jscraftcamp.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 83 (🔴 down 4 from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 99 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 4 months ago

Name	Link
Latest commit	38f0c6d3abb9652ed0c8df2d5ef9be20270da515
Latest deploy log	https://app.netlify.com/sites/jscraftcamp/deploys/664ef26e41c1240008e56e70
Deploy Preview	https://deploy-preview-2029--jscraftcamp.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 88 (🟢 up 5 from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 99 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 4 months ago

Name	Link
Latest commit	2c811f21e697f09675f69ca64fb174c7184c0c6a
Latest deploy log	https://app.netlify.com/sites/jscraftcamp/deploys/664e4d48c234c00008d8598f
Deploy Preview	https://deploy-preview-2029--jscraftcamp.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

harmeet24 commented 4 months ago

Hi @harmeet24 sorry, there is another change to be made. Looks like the X value didn't go through - no need for the @ sign there!

I fixed the issue, please have a look :)

harmeet24 commented 4 months ago

Hey @harmeet24, please add the json file extension to your newly added file!

done

meldron commented 4 months ago

Thanks a lot for fixing the PR, welcome to JSCC, see you there!

jscraftcamp / website