Allow indented "break" in "switch" statement.

[kaidjohnson]

The code that's failing:

switch(response.target) {
  case 'external':
    if (response.targetUrl) {
      $window.open(response.targetUrl);
    }
    break;

  default: 
    if (response.targetUrl) {
      $window.location = response.targetUrl;
    }
    break;
}

Error displayed (I've obscured the filename):

Expected indentation of 4 characters at /path/to/controller.js:
    55 |      $window.open(response.targetUrl);
    56 |     }
    57 |     break;
------------^
    58 |
    59 |    default:

Expected indentation of 4 characters at /path/to/controller.js :
    61 |      $window.location = response.targetUrl;
    62 |     }
    63 |     break;
------------^
    64 |   }
    65 |  });

I have the following rule in place in my .jscsrc:

"validateIndentation": "\t"

I know there are a few old tickets out there about allowing non-indented breaks in switch statements, but I believe this is a different issue and is specific to gulp-jscs only.

When I run these files through jscs directly, it passes.

jscs /path/to/controller.js // success !

When I run them as a gulp task, it fails:

const jscs = require('gulp-jscs');

gulp.task('jscs', () => 
  gulp.src(['app/**/*.js', 'test/**/*.js'])  
    .pipe(jscs()) 
    .pipe(jscs.reporter())
);

---

gulp jscs // fail !

When I only pass in one glob to gulp.src it passes:

const jscs = require('gulp-jscs');

gulp.task('jscs', () => 
  gulp.src(['app/**/*.js'])  
    .pipe(jscs()) 
    .pipe(jscs.reporter())
);       

---

gulp jscs // pass!

Am I doing something wrong? Any help would be much appreciated.

[kaidjohnson]

Using "gulp-jscs": "3.0.2"

[kaidjohnson]

Found the issue. I had non-indented breaks in my test files and indented breaks in my app files. When I reverse the order of the glob, the other set of files would fail. Need to adjust one or the other to match.

It's interesting to me that the break indentation is defined by the first file found in the glob but then enforced everywhere based on that file whereas quote rules can be defined so the first quote in a file determines the quote type used just in that file, rather than the entire glob. I would expect to see that same behavior regarding indentation, but I suppose that's a separate issue/feature request.