search

jscs-dev / jscs-jsdoc

JsDoc validation rules for jscs
MIT License
99 stars 35 forks source link

New Rule: Require Param Description #111

Closed dtracers closed 9 years ago

dtracers commented 9 years ago

New Rule that allows one to require a parameter description

Address #107

dtracers commented 9 years ago

I am not sure how to remove these other commits...

But this is a new rule!

qfox commented 9 years ago

I am not sure how to remove these other commits...

I'm trying to support convention from JSCS here, in JSCS we using http://jscs.info/contributing.html#pull-requests jQuery commit message guidelines.

To rebuild your git history you can use:

git remote add upstream https://github.com/jscs-dev/jscs-jsdoc.git
git fetch upstream
git rebase -i upstream//master

and then squash needed commits by their semantic.

p.s. Personally I'm using a lot: git pull --rebase upstream master as a shortcut for git fetch upstream; git rebase upstream/master

dtracers commented 9 years ago

okay I changed it around... I also somehow made everything worse in terms of commit history while trying to fix it... :/ lol

I will probably just delete the repo after this is merged in and then fork it again.

qfox commented 9 years ago

Do you mind if I squash all of these to 1 commit? ;-)

dtracers commented 9 years ago

please do! I was trying to do it locally and ended duplicating every single one... twice... :/