search

jscs-dev / jscs-jsdoc

JsDoc validation rules for jscs
MIT License
99 stars 35 forks source link

Sentences with trailing ). and ". (and similar) are marked invalid by requireDescriptionCompleteSentence rule #123

Closed weekens closed 9 years ago

weekens commented 9 years ago

The sentences like:

Handles user input (click or keypress).

should be considered valid by requireDescriptionCompleteSentence.

For now the rule yields Sentence must end with a period. message.

qfox commented 9 years ago

Regex failing, yup. Thanks for a report.

https://github.com/jscs-dev/jscs-jsdoc/blob/master/lib/rules/validate-jsdoc/require-description-complete-sentence.js#L35

wooorm commented 9 years ago

Just had the same when a tick was used before a period: Detach$node. It’s the \w on https://github.com/jscs-dev/jscs-jsdoc/blob/master/lib/rules/validate-jsdoc/require-description-complete-sentence.js#L35 which should probably be something else. \S maybe?

qfox commented 9 years ago

Definitely! ;-) Wanna tackle this?

wooorm commented 9 years ago

Will do