search

jscs-dev / jscs-jsdoc

JsDoc validation rules for jscs
MIT License
99 stars 35 forks source link

Rule "jsDoc" is already registered #131

Closed christianvuerings closed 9 years ago

christianvuerings commented 9 years ago

Using jscs version 2.0.0.

  1. Set .jscsrc to:

    {
 "plugins": [
   "jscs-jsdoc"
 ]
}
  2. Run jscs . in the command line.

You immediately get the following response: Rule "jsDoc" is already registered

christianvuerings commented 9 years ago

Also see #128

qfox commented 9 years ago

That's because jscs package now bundled with jscs-jsdoc and you don't need to register it by self.

upd: I'm just afraid of versioning...

/cc @markelog

christianvuerings commented 9 years ago

@zxqfox any proposal on how we might be able to fix this? Currently we need to use an older version of jscs to make jsDoc linting work.

qfox commented 9 years ago

For now you can move "plugins": ["jscs-jsdoc"] out of your .jscsrc to use bundled version of this plugin.

I'm still not sure how to resolve this issue to allow users install custom version of jsdoc plugin. Need some time to decide (or some contribution of a good guy ;-).

markelog commented 9 years ago

Honestly, don't see the problem there, we already have installed jscs-jsdoc plugin, so you don't need to put it in plugins

webuniverseio commented 9 years ago

@zxqfox I'm a good guy :) Let me know what you think is the best. My suggesting - lets remove jscs-jsdoc from jscs dependencies and finish https://github.com/jscs-dev/jscs-jsdoc/issues/128?

qfox commented 9 years ago

Closing this for now as resolved. If somebody still xp'd this issue — please let me know.