Closed ljharb closed 8 years ago
I'm not sure why this dep was pinned
Historical reasons of jscs guide.
Thanks! Going to merge this.
Thanks! When do you think a patch release could go out that includes this?
@ljharb Feels like it's not enough for full support of 0.8
. Can you take a look at https://travis-ci.org/jscs-dev/jscs-jsdoc/jobs/95137833 ?
Sorry for delay, releasing asap.
@zxqfox Note how it's in jscs-jsdoc/node_modules/jscs/node_modules/jscs-jsdoc/node_modules/comment-parser/index.js
- ie, it's in your dep jscs
, which hasn't yet updated its jscs-jsdoc
dep, so it still has the old comment-parser
in it :-)
After your publish, and the corresponding update in jscs
itself, this should all be fixed. (this is one of the issues that's solved automatically when properly using semver ranges instead of pinning deps)
Yeah, right. That's pretty weird and still funny how it's going.
I'll publish 1.3.0 in few hours. Thanks!
(I'm not sure why this dep was pinned, this means all the downstreams will need to manually bump to get this fix. hopefully using a proper semver range is acceptable)
v0.3.1 of comment-parser uses the
readable-stream
module, which allows compatibility with node 0.8 and earlier. Whether you want to support node 0.8 isn't important - for your module, this change will function identically for > 0.8, and simply won't break for this reason on <= 0.8 - a net win!