Closed kepta closed 8 years ago
@zxqfox Let me know what you think?
Looks good at all. Just need to fix nits.
I am sorry for the errors ommission, I will rebase. Kinda newbie
@zxqfox, I wanted your review on the padding with of sanitized HTML with 'x.' It's not the most elegant way, but I can't think of any other way to prevent RE_NEW_LINE_START_WITH_UPPER_CASE?
Oh, don't worry! I'm usually forgetting to check codestyle when going to foreign repo. Guess it's a common problem. :smirk_cat:
the padding with of sanitized HTML with 'x.'
+1 to this solution as strong and simple.
Another could be parsing, analyzing, etc. It's a kinda complex problem that needs additional research.
@zxqfox Does it look good now? I can't see the build icon now.
Yeah, lgtm. Ready to merge?
Yes :+1:
@zxqfox , friendly ping :)
This rule has been flagging comments with html tags. In this patch the html is sanitized with *\ so that it doesn't interfere with the regular regex tests. The htmlSanitizer function is padding all strings with 'x.' so that RE_NEW_LINE_START_WITH_UPPER_CASE doesnt fail. This will need to be improved after discussing with owner if he/she thinks so.
Fixes jscs-dev/node-jscs#2056