search

jscs-dev / node-jscs

:arrow_heading_up: JavaScript Code Style checker (unmaintained)
https://jscs-dev.github.io
MIT License
4.96k stars 513 forks source link

jsDoc checkTypes issue #2036

Closed jdalton closed 8 years ago

jdalton commented 8 years ago 
git clone --depth=1 https://github.com/lodash/lodash
cd lodash
npm i
npm run style

Notice it fail on a bunch of param names now. It used to not error. I think this just started recently.

markelog commented 8 years ago

Hey John, will check it out asap.

/cc @zxqfox

markelog commented 8 years ago

Don't see any errors :/. So okay, what node version? Did you try to remove node_modules?

jdalton commented 8 years ago

Odd, I can't repro it either now. The mucked up node_modules folder seems as good a reason as any. Thanks!

qfox commented 8 years ago

:+1:

jdalton commented 8 years ago

~~I take it back :grin:, I had a change in the config that removed the checkTypes directive which is why I wasn't seeing the fail. I'm seeing the fails on the current edge master branch with Node v5.1.1 npm v2.14.15, and JSCS 2.7.0.~~

And I take it back again. It turns out it's because I was running an edge version of lodash in my node_modules folder.