search

jscs-dev / node-jscs

:arrow_heading_up: JavaScript Code Style checker (unmaintained)
https://jscs-dev.github.io
MIT License
4.96k stars 510 forks source link

Convert disallow-unused-params to CST #2062

Closed mdevils closed 8 years ago

mdevils commented 8 years ago

Rule disallow-unused-params implementation using CST scopes.

TODO:

markelog commented 8 years ago

Could you add test-case for https://github.com/jscs-dev/node-jscs/issues/1946 ?

markelog commented 8 years ago

And https://github.com/jscs-dev/node-jscs/issues/2002

mdevils commented 8 years ago

TODO: Remove object pattern properties while fixing.

markelog commented 8 years ago

I see we all DONE here, just don't forget the git conventions (sorry :-)

hzoo commented 8 years ago

Not a big deal but we've been using https://github.com/jscs-dev/node-jscs/blob/master/CONTRIBUTING.md#commit-message-format

something like disallowUnusedParams: refactor to use CST

markelog commented 8 years ago

I guess @mdevils is a rebel!

just don't forget the git conventions (sorry :-)