validateNewlineAfterArrayElements: --fix now works for this rule

jscs-dev / node-jscs

:arrow_heading_up: JavaScript Code Style checker (unmaintained)

https://jscs-dev.github.io

MIT License

4.96k stars 510 forks source link

validateNewlineAfterArrayElements: --fix now works for this rule #2072

Closed joerideg closed 8 years ago

joerideg commented 8 years ago

Fixes #2065

markelog commented 8 years ago

Would you mind adding basic tests for autofixing? See example - https://github.com/jscs-dev/node-jscs/blob/c704e9e0713c5462a61dac309a6e6abd30098545/test/specs/rules/disallow-semicolons.js#L68-L74

joerideg commented 8 years ago

Will do!

joerideg commented 8 years ago

Quick update: Quite busy with work but will hopefully get to the test tomorrow or thursday.

markelog commented 8 years ago

Friendly ping

joerideg commented 8 years ago

I'll get around to it monday! Cheers

hzoo commented 8 years ago

I can do this today so don't worry about it

hzoo commented 8 years ago

Ok added tests in https://github.com/jscs-dev/node-jscs/commit/b86c8c28a8d5a0b95f12c85da260174a0f3b9922

joerideg commented 8 years ago

Cool! :) Can I remove my fork now? (this is my first pull request ever)

markelog commented 8 years ago

Yeah and congrats on your first contribution!

joerideg commented 8 years ago

Thanks!

hzoo commented 8 years ago

@joerideg Thanks so much for your PR (and first contribution)!

Ah I would recommend that (in the future) you create a branch

instead of sending a PR from your master branch.

Then you can just delete that branch (or leave it there). You don't really want to remove your fork (unless you aren't planning on contributing to the repo ever again). Sending your PR's through separate branches allows you to have multiple PR's at the same time if that becomes necessary (and it's the recommended way to do so).

joerideg commented 8 years ago

Ill keep that in mind, thanks!