Skipped tests2 - Githubissues

jscs-dev / node-jscs

:arrow_heading_up: JavaScript Code Style checker (unmaintained)

https://jscs-dev.github.io

MIT License

4.96k stars 513 forks source link

Skipped tests2 #2181

Closed hzoo closed 8 years ago

markelog commented 8 years ago

Judging by the travis log, it seems we need to increase the test timeout?

hzoo commented 8 years ago

Yeah only for those tests I guess

On Fri, Mar 18, 2016, 9:39 AM Oleg Gaidarenko notifications@github.com wrote:

Judging by the travis log, it seems we need to increase the test timeout?

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/jscs-dev/node-jscs/pull/2181#issuecomment-198364388

hzoo commented 8 years ago

Oh, I see - that sucks - so that timeout was for my computer

Means that the tests were taking < 3 sec and now > 15 which is pretty bad and something we certainly need to investigate?

coveralls commented 8 years ago

Coverage increased (+1.4%) to 96.426% when pulling bf7d1bf76735a5da6ae592f20b9a095ef800770b on hzoo:skipped-tests2 into 87c5daf26f4c02517121e8d7e969071057838958 on jscs-dev:master.

markelog commented 8 years ago

Means that the tests were taking < 3 sec and now > 15 which is pretty bad and something we certainly need to investigate?

Definitely! /cc @mdevils

coveralls commented 8 years ago

Coverage increased (+1.4%) to 96.426% when pulling dd1034bd24a1325a0cc5dd58d4c62cf54d6927e4 on hzoo:skipped-tests2 into 87c5daf26f4c02517121e8d7e969071057838958 on jscs-dev:master.

coveralls commented 8 years ago

Coverage increased (+1.4%) to 96.426% when pulling 052ca0c8a5d076f919c1ffbfd3c9d182206d4df7 on hzoo:skipped-tests2 into 87c5daf26f4c02517121e8d7e969071057838958 on jscs-dev:master.